Skip to content

fix import style for redis.lock and luigi.task_register#515

Merged
hirosassa merged 2 commits into
m3dev:masterfrom
hirosassa:fix-import-style
May 15, 2026
Merged

fix import style for redis.lock and luigi.task_register#515
hirosassa merged 2 commits into
m3dev:masterfrom
hirosassa:fix-import-style

Conversation

@hirosassa

Copy link
Copy Markdown
Collaborator

Summary

  • task_lock.py — Use from redis.lock import Lock instead of redis.lock.Lock attribute access
  • build.py — Use from luigi import task_register instead of luigi.task_register attribute access

Motivation

Pyright does not resolve submodules via attribute chain access (e.g. redis.lock.Lock) unless the parent package explicitly re-exports them. Switching to direct imports follows the same pattern already used in parameter.py and resolves 6 Pyright errors.

@hirosassa hirosassa enabled auto-merge (squash) May 15, 2026 00:03
@hirosassa hirosassa merged commit 8062ad3 into m3dev:master May 15, 2026
8 checks passed
@hirosassa hirosassa deleted the fix-import-style branch May 15, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants